pss: make *_with_salt methods the default
#291
Conversation
Similar to #290, this renames the following: - `Pss::new` => `Pss::new_unsalted` - `Pss::new_with_salt` => `Pss:new` - `Pss::new_blinded` => `Pss::new_blinded_unsalted` - `Pss::new_blinded_with_salt` => `Pss::new_blinded` - `SigningKey::new` => `SigningKey::new_unsalted` - `SigningKey::new_with_salt_len` => `SigningKey::new` - `SigningKey::random` => `SigningKey::random_unsalted` - `SigningKey::random_with_salt_len` => `SigningKey::random` The `*_with_salt` methods are preserved with a deprecation warning, which should help people migrate to the new versions. This also removes the `From<RsaPrivateKey>` impl for `SigningKey`, since users should consider up front whether or not they need a salt rather than defaulting to unsalted.
|
Generic comment: do we need the without salt functions at all? Let me suggest another approach. Basically even if |
|
I don't actually know if anyone uses unsalted PSS. Indeed It seems weird to have a separate API for it when someone who really wants it can specify a salt length of 0. Perhaps we should just get rid of the "unsalted" functions to simplify the API? |
|
Yes, that's my idea. Will post it shortly. |
|
I can just remove the |
|
@tarcieri slightly more than that (especially on the verification side). |
|
I like #294 as an alternative to this, but I'll leave this open for now until people have a chance to discuss |
|
Closed in favor of #294 |
Similar to #290, this renames the following:
Pss::new=>Pss::new_unsaltedPss::new_with_salt=>Pss:newPss::new_blinded=>Pss::new_blinded_unsaltedPss::new_blinded_with_salt=>Pss::new_blindedSigningKey::new=>SigningKey::new_unsaltedSigningKey::new_with_salt_len=>SigningKey::newSigningKey::random=>SigningKey::random_unsaltedSigningKey::random_with_salt_len=>SigningKey::randomThe
*_with_saltmethods are preserved with a deprecation warning, which should help people migrate to the new versions.This also removes the
From<RsaPrivateKey>impl forSigningKey, since users should consider up front whether or not they need a salt rather than defaulting to unsalted.cc @lumag