Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deref+port redo #108

Draft
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

YruamaLairba
Copy link
Contributor

hi, I reworked ports system to prevent having mutable reference to inplace output data I mentioned on #106

Notable change:

  • InputPort,OutputPort and PortType system is replaced by just types that are the ports.
  • There is now RCell and RwCell type used for inplace ports. RCell prevent is used to prevent writing through input port and RwCell is just here to be consistent with RCell
  • ports are organized in 2 module, inplace for ports supporting inplace processing and, not_inplace for ports not supporting inplace processing.

Current state:

  • i still need to update some plugin in docs folder
  • atom crate still broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant