Remove Sync requirement from ProcessHandler. (#121) #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts 356aec6.
This was referenced Jun 26, 2020
|
Hi @wmedrano, |
|
Hey @wmedrano, ping :)? |
|
I see wmedrano has no activity here on github since late April. |
|
This will be included in the 0.6.3 release. |
|
wheee thanks for merging! :) |
|
Fantastic, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts 356aec6.
A ProcessHandler is moved into
activate_asyncand thus can only be used by a single client.While in Jack2, process_callbacks of different clients can indeed run concurrently, the process_callback of a single client can not be concurrent with itself.
(The process_callback of a single client can run concurrently with the notification callbacks of the same client, and I am not sure whether the notification callback is also guaranteed to be non-self-concurrent.)