-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cargo-publish job #337
Conversation
@tomaka could you set up the secret as explained in the link above? I only see you as the crates.io owner of this crate. |
I don't have access to the settings of this repo. |
And I don't have publish rights on crates.io :) Could you you run |
@tomaka you should have admin rights now on this repo. |
Getting this:
|
I'm not sure I want to put my token in the settings of cpal, as this gives access to all my crates. However, now, anyone within the RustAudio orga could push something to master, or quickly submit-merge a PR, and publish a new version of any of my crates. |
I see your problem. I guess the issue is rust-lang/crates.io#849 . What about I create a cpal maintainers team that I add you to and then you add crates.io publish rights? Then anyone in that team could publish to crates.io, but they have to do it manually. |
Where was the token saved in |
Another alternative is creating a separate github account. |
What's the status of this one? |
@Luni-4 my hands are bound. Only owner of cpal is still tomaka: https://crates.io/crates/cpal |
I see. So let's wait for @tomaka decision then :) |
Alright, I've added a new github account @rustaudio-publish-bot . Also I've created a new team @RustAudio/cpal-maintainers which tomaka is now a member of. @tomaka can you try running |
@est31 Done! |
@tomaka wonderful, thank you! Now everything should be set up. Let's hope it works. |
@tomaka could you also add the team for the |
Done. |
This PR runs
cargo-publish
.To create the
CRATESIO_TOKEN
, you need to follow this guideThanks in advance for your review! :)