Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo-publish job #337

Merged
merged 1 commit into from
Oct 26, 2019
Merged

Add cargo-publish job #337

merged 1 commit into from
Oct 26, 2019

Conversation

Luni-4
Copy link
Contributor

@Luni-4 Luni-4 commented Oct 4, 2019

This PR runs cargo-publish.

To create the CRATESIO_TOKEN, you need to follow this guide

Thanks in advance for your review! :)

@est31
Copy link
Member

est31 commented Oct 5, 2019

@tomaka could you set up the secret as explained in the link above? I only see you as the crates.io owner of this crate.

@tomaka
Copy link
Collaborator

tomaka commented Oct 5, 2019

I don't have access to the settings of this repo.

@est31
Copy link
Member

est31 commented Oct 5, 2019

And I don't have publish rights on crates.io :)

Could you you run cargo owner --add github:rustaudio:cratesio-publish? Not sure though if it works if you're not part of the github team.

@est31
Copy link
Member

est31 commented Oct 5, 2019

@tomaka you should have admin rights now on this repo.

@tomaka
Copy link
Collaborator

tomaka commented Oct 7, 2019

Not sure though if it works if you're not part of the github team.

Getting this:

error: failed to invite owners to crate cpal: api errors (status 200 OK): only members of a team can add it as an owner

@tomaka
Copy link
Collaborator

tomaka commented Oct 7, 2019

I'm not sure I want to put my token in the settings of cpal, as this gives access to all my crates.
If I'm actively working on a repo, that's fine, as I might notice a PR that messes up with that.

However, now, anyone within the RustAudio orga could push something to master, or quickly submit-merge a PR, and publish a new version of any of my crates.

@est31
Copy link
Member

est31 commented Oct 7, 2019

I see your problem. I guess the issue is rust-lang/crates.io#849 .

What about I create a cpal maintainers team that I add you to and then you add crates.io publish rights? Then anyone in that team could publish to crates.io, but they have to do it manually.

@Luni-4
Copy link
Contributor Author

Luni-4 commented Oct 7, 2019

Where was the token saved in travis? Perhaps it could be possible to recreate the same situation. If you would describe the steps, I could change the Github Actions script.

@est31
Copy link
Member

est31 commented Oct 7, 2019

Another alternative is creating a separate github account.

@Luni-4
Copy link
Contributor Author

Luni-4 commented Oct 26, 2019

@est31

What's the status of this one?

@est31
Copy link
Member

est31 commented Oct 26, 2019

@Luni-4 my hands are bound. Only owner of cpal is still tomaka: https://crates.io/crates/cpal

@Luni-4
Copy link
Contributor Author

Luni-4 commented Oct 26, 2019

@Luni-4 my hands are bound. Only owner of cpal is still tomaka: https://crates.io/crates/cpal

I see. So let's wait for @tomaka decision then :)

@est31
Copy link
Member

est31 commented Oct 26, 2019

Alright, I've added a new github account @rustaudio-publish-bot . Also I've created a new team @RustAudio/cpal-maintainers which tomaka is now a member of.

@tomaka can you try running cargo owner --add github:rustaudio:cpal-maintainers for the cpal crate? Then the bot account will be allowed to publish cpal to crates.io and we can use its token in this PR. The bot account will only ever have access to RustAudio crates so its impact will be limited.

@tomaka
Copy link
Collaborator

tomaka commented Oct 26, 2019

@est31 Done!

@est31
Copy link
Member

est31 commented Oct 26, 2019

@tomaka wonderful, thank you! Now everything should be set up. Let's hope it works.

@est31 est31 merged commit dca5a11 into RustAudio:master Oct 26, 2019
@Luni-4
Copy link
Contributor Author

Luni-4 commented Oct 26, 2019

Thank you @est31 and @tomaka! :)

@Luni-4 Luni-4 deleted the github-actions branch October 26, 2019 12:29
@est31
Copy link
Member

est31 commented Oct 26, 2019

@tomaka could you also add the team for the alsa-sys crate? It's in the same repo as this one.

@tomaka
Copy link
Collaborator

tomaka commented Oct 26, 2019

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants