Disable rustfmt on the bindings, as it can occasionally cause build breakage #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #7. |
|
By default, bindgen will run rustfmt on the generated bindings (internally in bindgen, not user requested). This can sometimes mess up the generated code so it doesn't compile. This PR disables that default behaviour. |
glandium
added a commit
to glandium/coreaudio-sys
that referenced
this pull request
Jul 26, 2019
Because recent versions of bindgen generate their bindings on one line, because of bindgen's use of u128 and rust's warnings of its unsafety FFI-wise, and because of rust-lang/rust#62999, combined, building the crate generates massive logs... which exceed travis's maximum log length. It was disabled in RustAudio#13 because back then rustfmt had some problems with the bindgen output. Now that rustfmt is part of rust, these kind of problems presumably should happen less if at all.
glandium
added a commit
to glandium/coreaudio-sys
that referenced
this pull request
Jul 26, 2019
Because recent versions of bindgen generate their bindings on one line, because of bindgen's use of u128 and rust's warnings of its unsafety FFI-wise, and because of rust-lang/rust#62999, combined, building the crate generates massive logs... which exceed travis's maximum log length. It was disabled in RustAudio#13 because back then rustfmt had some problems with the bindgen output. Now that rustfmt is part of rust, these kind of problems presumably should happen less if at all.
glandium
added a commit
to glandium/coreaudio-sys
that referenced
this pull request
Aug 6, 2019
Because recent versions of bindgen generate their bindings on one line, because of bindgen's use of u128 and rust's warnings of its unsafety FFI-wise, and because of rust-lang/rust#62999, combined, building the crate generates massive logs... which exceed travis's maximum log length. It was disabled in RustAudio#13 because back then rustfmt had some problems with the bindgen output. Now that rustfmt is part of rust, these kind of problems presumably should happen less if at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is