Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrappers for SDL 2.0.9 rumble functions #824

Merged
merged 7 commits into from
Dec 12, 2018
Merged

Add wrappers for SDL 2.0.9 rumble functions #824

merged 7 commits into from
Dec 12, 2018

Conversation

Manorhos
Copy link
Contributor

I added sdl2::controller::set_rumble and sdl2::joystick::set_rumble, wrappers for the two new (since SDL 2.0.9) rumble functions SDL_GameControllerRumble and SDL_JoystickRumble respectively.
The game-controller and joystick examples were also extended to test them a little.

@Manorhos
Copy link
Contributor Author

Manorhos commented Dec 10, 2018

Travis seems to fail without the bundled feature, because the script for installing SDL2 still seems to download version 2.0.8...

@Cobrand
Copy link
Member

Cobrand commented Dec 11, 2018

Weird that we didnt catch that earlier. Can you update the travis file to use 2.0.9 real quick?

@Manorhos
Copy link
Contributor Author

Yeah, I'll do that.

@@ -3,6 +3,9 @@ when upgrading from a version of rust-sdl2 to another.

### v0.32

[PR #824](https://github.com/Rust-SDL2/rust-sdl2/pull/824):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the changelog, technically, 0.32 is already released, so make a new category "v0.32.1 (unreleased)" and put those changes there instead. Otherwise, people will wonder why this rumble feature is not part of 0.32 on crates.io.

Other than than, looks good to me! I tested the update example locally on my computer with a Xbox 360 controller, works really well!

Copy link
Contributor Author

@Manorhos Manorhos Dec 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wasn't so sure about that myself... What you proposed sounds good, I'm gonna do that.

Edit: Oh, and I'm glad it also works fine for you! The 2.0.9 rumble feature really is great, especially with the HIDAPI stuff they added.

@Cobrand Cobrand merged commit b6fa720 into Rust-SDL2:master Dec 12, 2018
sypwex pushed a commit to sypwex/rust-sdl2 that referenced this pull request Jun 2, 2024
Add wrappers for SDL 2.0.9 rumble functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants