Add Music::from_bytes() function #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cobrand
reviewed
Sep 10, 2017
src/sdl2/mixer/mod.rs
Outdated
| @@ -790,6 +790,28 @@ impl<'a> Music<'a> { | |||
| } | |||
| } | |||
|
|
|||
| /// Load music from a byte buffer. | |||
| pub fn from_bytes(buf: &[u8]) -> Result<Music<'static>, String> { | |||
There was a problem hiding this comment.
This is pretty unsafe, if the &[u8] comes from a Vec that gets destroyed right afterwards, this will probably crash, unless I'm missing something.
Please replace that by &'static [u8], and change the fn name to from_static_bytes.
There was a problem hiding this comment.
You're right; I tried that and it crashed immediately.
|
Would you mind adding an entry for that in the changelog for 0.31 as well? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution to issue #696.