Expand bundled testing to linux and macos #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand Linux "bundled" testing to also cover release and static variants. Has the added benefit that this testing doesn't accidentally see teh libsdl packages that were installed as part of the pkg-config testing. While here, try enabling for macos as well to gather coverage for it.
|
Noticed you rebased, is this ready to merge? |
|
Yes this is ready to go. Thanks! |
sypwex
pushed a commit
to sypwex/rust-sdl2
that referenced
this pull request
Jun 2, 2024
Expand bundled testing to linux and macos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand Linux "bundled" testing to also cover release and static
variants. Has the added benefit that this testing doesn't accidentally
see the libsdl packages that were installed as part of the pkg-config
testing.
While here, try enabling for macos as well to gather coverage for it.