Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory safety bug in set_error #1057

Merged
merged 4 commits into from
Dec 23, 2020
Merged

fix memory safety bug in set_error #1057

merged 4 commits into from
Dec 23, 2020

Conversation

LunarLambda
Copy link
Contributor

fixes #1056 by passing "%s" as the format string to SDL_SetError instead of the message string.

@LunarLambda LunarLambda changed the title Fix set error fix memory safety bug in set_error Dec 23, 2020
@LunarLambda
Copy link
Contributor Author

LunarLambda commented Dec 23, 2020 •
edited
Loading

I'm not sure how to run cargo fmt only on sdl.rs. It formats like 4 other unrelated files.

edit: got it

@Cobrand
Copy link
Member

Cobrand commented Dec 23, 2020

Looks good to me, thanks!

@Cobrand Cobrand merged commit 831dba0 into Rust-SDL2:master Dec 23, 2020
@LunarLambda LunarLambda deleted the fix-set-error branch December 23, 2020 11:26
@LunarLambda LunarLambda mentioned this pull request Dec 23, 2020
Closed
sypwex pushed a commit to sypwex/rust-sdl2 that referenced this pull request Jun 2, 2024
@Cobrand
Merge pull request Rust-SDL2#1057 from LunarLambda/fix-set-error
b5d23a3 
fix memory safety bug in set_error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set_error can violate memory safety
2 participants
@LunarLambda @Cobrand