Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundled SDL2 to 2.0.12 #1027

Merged
merged 1 commit into from
Sep 13, 2020

Conversation

aclysma
Copy link
Contributor

@aclysma aclysma commented Sep 12, 2020

This would resolve #1025

The patch that was removed was added upstream here: spurious/SDL-mirror@85acfec#diff-af3b638bc2a3e6c650974192a53c7291

The patch required for #1025 should be included as well: spurious/SDL-mirror@97b93a8#diff-af3b638bc2a3e6c650974192a53c7291

The patch based on this commit remains: spurious/SDL-mirror@86c309a#diff-af3b638bc2a3e6c650974192a53c7291

@aclysma
Copy link
Contributor Author

aclysma commented Sep 12, 2020

On testing:

  • I was able to run the game of life example on macOS
  • Some things failed to link for me on macOS, but they failed to link for me on current latest as well.

This is not thoroughly tested, just trying to help on #1025 because I think @uhuntu has already had to bounce through multiple projects to track this down and I feel that properly working IME is very important.

@aclysma aclysma mentioned this pull request Sep 12, 2020
@Cobrand
Copy link
Member

Cobrand commented Sep 13, 2020

It looks great, thanks! I tested it both with bundled and without and linux and nothing unusual.

@Cobrand Cobrand merged commit cde7faa into Rust-SDL2:master Sep 13, 2020
@Cobrand
Copy link
Member

Cobrand commented Sep 13, 2020

sdl2-sys 0.34.3 has been pushed on crates.io. sdl2 itself is unchanged since 0.34.3, technically a cargo update in your command line should be enough to update sdl2-sys to the latest version.

sypwex pushed a commit to sypwex/rust-sdl2 that referenced this pull request Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants