Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable extraction of results in SMTBackend.solve, fix examples #14

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bpowers
Copy link

@bpowers bpowers commented Nov 1, 2016

Examples and tests were broken due to trivial changes to APIs (and
renaming of the crate from libsmt -> rustproof_libsmt).

One thing is that this reverts 'bug fix for hanging', which I think
was due to calling '(exit)' twice in the case of a Sat result from
solve(). I think the right thing to do is not call exit at all -- z3
will exit on its own if the write end of its stdin is closed
(returning EOF to z3), as should happen when the rust process exits,
and besides, we might want to iteratively invoke solve (with
appropriate push/pop context calls) on the same z3 instance.

@bpowers
Copy link
Author

bpowers commented Nov 1, 2016

let me know if you want me to split this up into 2 PRs -- its sort of messy as is.

@arc3x
Copy link

arc3x commented Nov 3, 2016

This is fine. We will review it this weekend.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants