Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support signed integers for bswap intrinsic #174

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support signed integers for bswap intrinsic #174

wants to merge 1 commit into from

Conversation

LegNeato
Copy link
Collaborator

@LegNeato LegNeato commented Dec 9, 2024

Fixes #169

@LegNeato
Copy link
Collaborator Author

LegNeato commented Dec 9, 2024 •
edited
Loading

Not sure where we add runtime tests? Edit: Looks like we don't have these yet :-(

@LegNeato
Copy link
Collaborator Author

LegNeato commented Dec 10, 2024 •
edited
Loading

@FractalFir No rush, but I would love it if you can confirm this fixes the issue you saw. If you are busy, no worries (I did a couple of manual tests)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb Awaiting requested review from eddyb eddyb is a code owner

@fornwall fornwall Awaiting requested review from fornwall fornwall is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

buggy bswap implementation seems to assume unsigned arguments
1 participant
@LegNeato