[E0592] method or associated functions already defined with same names

[MahadMuhammad]

Multiple candidated for method or function - E0592

• Added errorcode & rich location.

Running testcases:

• gcc/testsuite/rust/compile/generics7.rs
• gcc/testsuite/rust/compile/issue-925.rs

Output:

../mahad-testsuite/E0592.rs:28:7: error: duplicate definitions with name ‘bar’ [E0592]
    9 |     fn bar(self) -> isize {
      |     ~~ 
      |     duplicate definitions for bar
......
   21 |     fn bar(self) -> T {
      |     ~~ 
      |     duplicate definitions for bar
......
   28 |     a.bar();
      |       ^~~

gcc/rust/ChangeLog:

* typecheck/rust-hir-type-check-expr.cc (TypeCheckExpr::visit): Added rich location and errorcode.

gcc/testsuite/ChangeLog:

* rust/compile/generics7.rs: Updated comment.
* rust/compile/issue-925.rs: likewise.

[CohenArthur]

hm, not sure which message we should keep here and which error code we should use

[CohenArthur]

I think we should keep the original error message, as this one could confuse the user since the error will appear on the use site rather than the definition site

[MahadMuhammad]

Done :)

[philberty]

@MahadMuhammad this has merge conflicts can you fix it up?

[MahadMuhammad]

@philberty, Sure thing. I'll do it :)

[CohenArthur]

@MahadMuhammad the tests are failing, once this is fixed I'll merge this