Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gccrs: improve name mangling hash #2551

Merged
merged 1 commit into from
Aug 12, 2023
Merged

gccrs: improve name mangling hash #2551

merged 1 commit into from
Aug 12, 2023

Conversation

philberty
Copy link
Member

We can endup with duplicate symbol names for different intrinsics with our current hash setup. This adds in the mappings and extra info to improve hash uniqueness.

Addresses #1895

gcc/rust/ChangeLog:

* backend/rust-compile-intrinsic.cc (check_for_cached_intrinsic): simplify this cached intrinsic check
* backend/rust-mangle.cc (legacy_mangle_item): use new interface
* typecheck/rust-tyty.h: new managle helper

We can endup with duplicate symbol names for different intrinsics with our
current hash setup. This adds in the mappings and extra info to improve
hash uniqueness.

Addresses #1895

gcc/rust/ChangeLog:

	* backend/rust-compile-intrinsic.cc (check_for_cached_intrinsic):
	simplify this cached intrinsic check
	* backend/rust-mangle.cc (legacy_mangle_item): use new interface
	* typecheck/rust-tyty.h: new managle helper

Signed-off-by: Philip Herron <[email protected]>
@philberty philberty added the bug label Aug 12, 2023
@philberty philberty added this to the GCC 14 Stage 3 milestone Aug 12, 2023
@philberty philberty self-assigned this Aug 12, 2023
@philberty philberty added this pull request to the merge queue Aug 12, 2023
Merged via the queue into master with commit b1dd423 Aug 12, 2023
9 checks passed
@philberty philberty deleted the phil/mangling branch September 17, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant