Legacy dummy hash causes duplicate symbols #428
Comments
bors bot
added a commit
that referenced
this issue
May 14, 2021
430: Add FNV-128 hash for legacy symbol mangling r=philberty a=philberty Rustc uses a SIP128 hash for the legacy symbol mangling but an FNV hash is simpler to implement. This is a port of the implementation from golang stdlib hash package. The fingerprint for the hash is simply the function signature for now. Rustc takes into account options such as -Cmetadata to generate uniqueness. We still need to implement a SIP128 hasher and the V0 symbol mangling but this will do in the interim. Addresses: #305 Fixes: #428 Co-authored-by: Philip Herron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The symbol mangling issue #305 currently only implemented a dummy hash the legacy hash encompasses function generic parameters as well as we can see from compiler explorer:
https://godbolt.org/z/nT8PcjPG4
The mangled symbol does not contain anything to do with the generic parameters but the hashes are not duplicated.
The text was updated successfully, but these errors were encountered: