Add "| None" type annotation for args that can be None
#388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, many arguments are annotated as type
Type
(e.g.Meshcat
) while their default value is set toNone
. This "implicit optional" convention, which was acceptable in the past, is now discouraged by PEP-484 [1]. It causes my editor to show "unreachable code" warnings since it assumes these arguments cannot be None.This PR fixes the type annotation from
Type
toType | None
.There is an older way to denote
typing.Union[Type, None]
, which istyping.Optional[Type]
.Type | None
was introduced in PEP-604. Both are valid. There is no precedent in the manipulation repo, while both have been used in Drake [2, 3].However,
Type | None
seems to be encouraged by Python developers [4, 5] overtyping.Optional
.This change is