Fix the socket.io breaking client applications due to default path used #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
- Coverage 63.88% 58.33% -5.56%
==========================================
Files 2 2
Lines 288 288
==========================================
- Hits 184 168 -16
- Misses 104 120 +16
Continue to review full report at Codecov.
|
|
@noxxious Please can you read the contribution guidelines and if in agreement add your name to the AUTHORS.md to acknowledge acceptance so that we can accept this PR |
robbinspg
suggested changes
Feb 15, 2018
|
Updated according to the comments. |
robbinspg
approved these changes
Feb 23, 2018
robbinspg
added a commit
that referenced
this pull request
Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue #109.