Merge pull request #122 from RuneLabsxyz/logging-stuff

feat: add some logging
RuneLabsxyz · Oct 9, 2024 · 145e516 · 145e516
2 parents 618a12e + f22caf2
commit 145e516
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/client/src/lib/3d/Scene.svelte b/client/src/lib/3d/Scene.svelte
@@ -67,12 +67,16 @@
   const animationLoop = () => {
     try {
       if ($birdView) {
-        if (birdViewCamera) {
+        if (birdViewCamera && birdViewCamera.isCamera) {
           resetCamera(birdViewCamera, renderer)
-          renderer.render(scene, birdViewCamera)
+          if (scene && scene.isScene) {
+            renderer.render(scene, birdViewCamera)
+          }
         }
       } else {
-        renderCameras(cameras, numCameras, renderer, scene)
+        if (cameras.length > 0 && cameras.every(cam => cam && cam.isCamera)) {
+          renderCameras(cameras, numCameras, renderer, scene)
+        }
       }
 
       if ($recordingMode) {
@@ -94,6 +98,9 @@
       animationFrameId = requestAnimationFrame(animationLoop)
     } catch (error) {
       console.error('Error in animation loop:', error)
+      if (error instanceof TypeError && error.message.includes('byteLength')) {
+        console.warn('Possible issue with buffer or geometry.')
+      }
     }
   }
 

diff --git a/client/src/lib/3d/utils/shootUtils.ts b/client/src/lib/3d/utils/shootUtils.ts
@@ -33,6 +33,11 @@ function applyBulletToStore(newBullet: BulletCoords) {
 }
 
 export function shoot(camera: PerspectiveCamera) {
+  if (!camera || !camera.isCamera) {
+    console.error('Invalid camera object')
+    return
+  }
+
   let move_index = Math.floor(get(frameCounter) / 3)
 
   let direction = getYawAngle(camera)
@@ -47,6 +52,10 @@ export function shoot(camera: PerspectiveCamera) {
   )
 
   recordedMove.update((rm) => {
+    if (!rm || !Array.isArray(rm.shots)) {
+      console.error('Invalid recordedMove structure')
+      return rm
+    }
     rm.shots.push({ angle: direction, step: move_index })
     console.log(rm.shots)
     return rm