support more bip32 params for chains #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per
https://github.com/satoshilabs/slips/blob/master/slip-0132.md
and
https://electrum.readthedocs.io/en/latest/xpub_version_bytes.html
SSP will now use proper version bytes of bip32 for extended public keys. This affects bitcoin networks only which is the only network specifying it for segwit properly. Other networks will follow P2SH bip32 specifications unless they specify.
SSP will always support BOTH version bytes. Defaulting to registered slip value with a fallback to default p2sh value of the network.
Already synced chains of ssp will display the synced version of xpub. Newly synced chains will display new verisons. Restoration will force new version of version bytes.
For compatibility reasons both ssp wallet and ssp key need to be updated in case of syncing some chain. Compatibility is kept for existing wallets.
Both bip32 versions bytes generate the same keypairs, addresses, only human readable version of extended keys is affected.