ENG 3056 Cannot delete resource when no workflow is using it #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-3050-fix-a-bug-where-edit-resource-dialog-crashes
likawind
requested changes
May 28, 2023
There was a problem hiding this comment.
@kenxu95 I'm fairly sure that you've migrated this request and we should use one of useResourceOperatorsGetQuery or useResourceWorkflowsGetQuery here: https://github.com/aqueducthq/aqueduct/blob/main/src/ui/common/src/handlers/v2/ResourceOperatorsGet.ts
eunice-chan
changed the base branch from
eng-3050-fix-a-bug-where-edit-resource-dialog-crashes
to
main
likawind
approved these changes
May 31, 2023
eunice-chan
added
the
skip_integration_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where the user cannot delete a resource when no workflow is using it. The cause is because the confirm dialog never pops up because resource operators.status is stuck at initial. This is due to the fact
handleLoadResourceOperatorsis never dispatched. To fix this, I dispatchhandleLoadResourceOperatorsin the resource details page.--
Updated to V2 route.
Tested by successfully deleting MariaDB resource.