Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(license): update spdx id in docs #30

Merged
merged 1 commit into from
Jun 9, 2024
Merged

chore(license): update spdx id in docs #30

merged 1 commit into from
Jun 9, 2024

Conversation

chenrui333
Copy link
Contributor

followup #26


missed it in the first place

@ccmywish
Copy link
Contributor

ccmywish commented Jun 9, 2024

Thank you Rui @chenrui333 , 🤝

I'm not very familiar with license issues, so I need to consult you about it.

I'm not sure if it's "dual license" as people understand. And I admit the sentence this PR focused on is kind of misleading.


This project includes a file called ./include/xy.h, which is a common C lib file I write to help to make program chsrc.c and chsrc.h easily. I want to make the xy.h more permissive, so I can use it in other non-GPL-3.0-or-later projects

I want to make chsrc only GPL-3.0-or-later. and chsrc is based on the MIT licensed ./include/xy.h

So, according to my idea above, is my situation called dual licensed? Does the two licenses conflict?

@chenrui333
Copy link
Contributor Author

chenrui333 commented Jun 9, 2024

I'm not sure if it's "dual license" as people understand. And I admit the sentence this PR focused on is kind of misleading.

it is not dual license, so that is reason why it should use and rather than or

technically, I would also split the license file into two and just contain the standard body from the license templates (it would also help github, but not fully), that means github would display two licenses rather than custom license for now (but not show the license semantics like and or or). Let me know if that makes better sense.

@ccmywish
Copy link
Contributor

ccmywish commented Jun 9, 2024

Well and clearly explained!

@ccmywish ccmywish merged commit 4960642 into RubyMetric:main Jun 9, 2024
ccmywish added a commit that referenced this pull request Jun 9, 2024
[GitHub link #30]
@chenrui333
Copy link
Contributor Author

THanks @ccmywish! 🙌

you can see now, it looks a bit better :)

image

@chenrui333 chenrui333 deleted the update-license branch June 9, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants