Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Group): Use flexbox styles for growing group child elements #3863

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

markhigham
Copy link
Collaborator

Overview

Changed styling of group component to use flex:1 property when Group has grow=true

Reason

The widths were previously hardcoded and used a css calc expression. It is simpler to use flex

Work carried out

Example.

  • Update Group component with new syntax
  • Update stories
  • Updated unit tests

@markhigham markhigham requested a review from m7kvqbe1 as a code owner August 16, 2024 15:25
Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for storybook-navy-digital-mod-uk ready!

Name Link
🔨 Latest commit c477492
🔍 Latest deploy log https://app.netlify.com/sites/storybook-navy-digital-mod-uk/deploys/66bf6f60ecd44400082cc99f
😎 Deploy Preview https://deploy-preview-3863--storybook-navy-digital-mod-uk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@markhigham markhigham requested a review from will-lamb August 19, 2024 07:43
@markhigham markhigham merged commit 889b914 into master Aug 19, 2024
22 of 23 checks passed
@markhigham markhigham deleted the fix-layout-components branch August 19, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants