Merge pull request doctrine#4364 from morozov/issues/4359

Move the logic out of the assertion
Rossmann-IT · Oct 20, 2020 · bc61ebe · bc61ebe
2 parents 1f72f05 + eb34f48
commit bc61ebe
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/lib/Doctrine/DBAL/Schema/PostgreSqlSchemaManager.php b/lib/Doctrine/DBAL/Schema/PostgreSqlSchemaManager.php
@@ -154,11 +154,8 @@ protected function _getPortableTableForeignKeyDefinition($tableForeignKey)
             $onDelete = $match[1];
         }
 
-        assert(preg_match(
-            '/FOREIGN KEY \((.+)\) REFERENCES (.+)\((.+)\)/',
-            $tableForeignKey['condef'],
-            $values
-        ) !== 0);
+        $result = preg_match('/FOREIGN KEY \((.+)\) REFERENCES (.+)\((.+)\)/', $tableForeignKey['condef'], $values);
+        assert($result === 1);
 
         // PostgreSQL returns identifiers that are keywords with quotes, we need them later, don't get
         // the idea to trim them here.