Adds ability to add canned acl to upload_data function #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcsorley
reviewed
Jul 30, 2020
dmcsorley
reviewed
Jul 30, 2020
ErinLMoore
force-pushed
the
add-bucket-object-acl-elm
branch
from
2a572cf
to
eb4a6cc
Compare
dmcsorley
approved these changes
Jul 31, 2020
bmulholand
approved these changes
Jul 31, 2020
ErinLMoore
force-pushed
the
add-bucket-object-acl-elm
branch
5 times, most recently
from
b156c7d
to
3a3eda0
Compare
ErinLMoore
changed the title
ErinLMoore
force-pushed
the
add-bucket-object-acl-elm
branch
from
3a3eda0
to
e12c7a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a need to add a canned ACL to objects we're putting in an S3 bucket that's owned by a third party. This adds that functionality to the existing
upload_datafunction.