Add locking of tags. #6
Conversation
|
@gjuchault Would you mind checking this and I get it published :) |
|
I'll try this week-end :) |
There was a problem hiding this comment.
Hey ! As @gjuchault is pretty busy at this time, I just tried to test the PR but I'm not able to compile it !
# Conflicts: # CHANGELOG.md # package.json # plugin.xml
|
@lonk omg. How silly of me. I didn't have the tools easily available to compile it back then (I use PhoneGap Build). Thus, the syntax errors. Fixed all of those now and merged also the latest master in. Could you please try again. |
|
Hey. Fixed those too! It should be available now with beta tag in npm: https://www.npmjs.com/package/cordova-plugin-mifare-ultralight |
|
It looks like 1.1.0 hasn't been updated, according to npm ! |
|
Hmm.. it shows up there in npm 🤔 |
|
There's now 1.1.1 marked as beta. I've got no clue how the npm publishing works.. |
| // 3. Read the protection page to be able to only modify certain bits and then write it again | ||
| response = mifare.readPages(protectionPage); | ||
| if ((response != null) && (response.length >= 16)) { | ||
| data = { |
There was a problem hiding this comment.
Got a an error just here at compilation:
error: illegal start of expression data = {
I'm not a Java developper so I don't know how to fix it actually :/
Maybe by modifying each entry on the array like data[0] = foo, data[1] = bar, etc .?
There was a problem hiding this comment.
Tried that with beta release 1.1.2.. :)
There was a problem hiding this comment.
Got the exact same issue on line 75 ! (sorry for the delay, I'm working at Disneyland on weekends so I'm too exhausted to code after my shift :'))
There was a problem hiding this comment.
I should've probably checked that too.. Fixed now in beta release 1.1.3 (I wish I understood the npm publishing as 1.1.0-beta.0 was not a valid semver according to npm).
Take your time. I don't need this feature myself nor do I use the plugin really nowadays :)
There was a problem hiding this comment.
Here are the last errors I get: https://pastebin.com/pgX12tTf
There was a problem hiding this comment.
1.1.4 available :)
Closes #5.