Mews Assignment #1
Conversation
This reverts commit d37ad23.
…the results with a debounce, and added in a button that allows you to go back to the search page from the movie detail page
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 987b91e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
|
|
||
| public searchMovies(searchQuery?: string, page = 1): void { | ||
| if (searchQuery) { | ||
| this.searchQuery = searchQuery; |
There was a problem hiding this comment.
This is so that when we go into the movie detail page, then back to the search page, and click next page, that the pagination continues to work.
If the search query was not saved then the pagination would not work.
| }); | ||
|
|
||
| it('should be created', () => { | ||
| expect(service).toBeTruthy(); |
There was a problem hiding this comment.
this test tests something that happens outside of it ?
There was a problem hiding this comment.
This is the default test that comes with service.
It just checks that the service has instantiated correctly.
| }); | ||
|
|
||
| it('should be created', () => { | ||
| expect(service).toBeTruthy(); |
There was a problem hiding this comment.
this test tests something that happens outside of it ?
There was a problem hiding this comment.
also nice that you wrote tests. But they do nothing usefull :D
There was a problem hiding this comment.
So this is the default test that comes with the service :)
It just checks that the service has instantiated correctly.
|
|
||
| it('should render title', () => { | ||
| const fixture = TestBed.createComponent(HomeComponent); | ||
| fixture.detectChanges(); |
There was a problem hiding this comment.
why not use global fixture and component that is handled in beforeEach ?
There was a problem hiding this comment.
For this piece of code I actually should have remove line 33 since I already have the fixture defined on line 23.
This was a miss on my side.
Line 33 was the default code that I forgot to remove.
| fixture.detectChanges(); | ||
| const compiled = fixture.nativeElement as HTMLElement; | ||
| expect( | ||
| compiled.querySelector('mat-toolbar span.title')?.textContent |
There was a problem hiding this comment.
what can we do to prevent failure of this selector when DOM is changed ?
There was a problem hiding this comment.
The selector mat-toolbar span.title will always be present in this component so it should never fail.
Could you elaborate on the potential failure?
No description provided.