Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AttackMaster Save mod table & save fail cmd #1945

Merged
merged 3 commits into from
Jun 18, 2024
Merged

AttackMaster Save mod table & save fail cmd #1945

merged 3 commits into from
Jun 18, 2024

Conversation

DameryDad
Copy link
Contributor

  • Added table for saving throw modifiers to make them more traceable and explainable, along with the --set-savemod command to add, change and remove mods.
  • Corrected default ToHit dice spec in getToHitRoll().
  • Replaced MIrowref lookup with itemIndex in attack commands as may be wrong at time of attack.
  • Added ^^distPB^^, ^^distS^^, ^^distM^^, and ^^distL^^ tags to Ranged Weapon attack macro templates to display range distances.
  • Add an optional fail command to saving throw macros, to support targeted saves provided by RoundMaster.
  • Add automatic saves on natural 20 & fail on 1, switchable as a configuration option

@DameryDad
Fixes to data parse, or which have no +:
3fe2d36 
* Modified reItemData to accept space or comma after a data section.
* Fix attack macro build for weapons that don't have a +: tohit attribute specified.
* Fixed weapon proficiency with complex innate weapons and spells
@DameryDad
Save mod table & save fail cmd
9a993dc 
* Added table for saving throw modifiers to make them more traceable and explainable, along with the --set-savemod command to add, change and remove mods.
* Corrected default ToHit dice spec in getToHitRoll().
* Replaced MIrowref lookup with itemIndex in attack commands as may be wrong at time of attack.
* Added ^^distPB^^, ^^distS^^, ^^distM^^,  and ^^distL^^ tags to Ranged Weapon attack macro templates to display range distances.
* Add an optional fail command to saving throw macros, to support targeted saves provided by RoundMaster.
* Add automatic saves on natural 20 & fail on 1, switchable as a configuration option
@DameryDad
Merge branch 'master' into AttackMaster
c0bae25
@DameryDad DameryDad mentioned this pull request Jun 7, 2024
Merged
@DameryDad
Copy link
Contributor Author

This pull request must not be merged without Pull Request #1943 also being merged

@Alicekb Alicekb merged commit e659fa9 into Roll20:master Jun 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alicekb Alicekb Alicekb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DameryDad @Alicekb