Test123 #19
Test123 #19
Conversation
…r testing git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/ZOOKEEPER-823@1022635 13f79535-47bb-0310-9956-ffa450edef68
![cs-rok-onprem-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53562?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
✅ Positive Code Health Impact (highest to lowest):
- String Heavy Function Arguments ClientBase.java
| @@ -43,6 +43,7 @@ | |||
| import org.apache.zookeeper.KeeperException; | |||
| import org.apache.zookeeper.PortAssignment; | |||
| import org.apache.zookeeper.TestableZooKeeper; | |||
| import org.apache.zookeeper.ThreadUtil; | |||
There was a problem hiding this comment.
✅ No longer an issue: String Heavy Function Arguments
The ratio of strings in function arguments is no longer above the threshold
There was a problem hiding this comment.
✅ Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
✅ Positive Code Health Impact (highest to lowest):
- String Heavy Function Arguments ClientBase.java
There was a problem hiding this comment.
✅ Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
✅ Positive Code Health Impact (highest to lowest):
- String Heavy Function Arguments ClientBase.java
| @@ -43,6 +43,7 @@ | |||
| import org.apache.zookeeper.KeeperException; | |||
| import org.apache.zookeeper.PortAssignment; | |||
| import org.apache.zookeeper.TestableZooKeeper; | |||
| import org.apache.zookeeper.ThreadUtil; | |||
There was a problem hiding this comment.
ℹ Getting worse: Primitive Obsession
The ratio of primitive types in function arguments increases from 66,67% to 67,65%, threshold = 30,0%
Why does this problem occur?
The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments. Read more.
To ignore this warning click here.
There was a problem hiding this comment.
✅ Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
✅ Positive Code Health Impact (highest to lowest):
- String Heavy Function Arguments ClientBase.java
fdffd