Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch 3.3 #1

Open
wants to merge 121 commits into
base: master
Choose a base branch
from
Open

Branch 3.3 #1

wants to merge 121 commits into from

Conversation

RokLenarcic
Copy link
Owner

No description provided.

phunt and others added 30 commits March 19, 2010 18:06
@phunt
Branching for 3.3 releases
4e7af54 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@925358 13f79535-47bb-0310-9956-ffa450edef68
@phunt
Preparing for release 3.3.0
e9d396d 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@925372 13f79535-47bb-0310-9956-ffa450edef68
ZOOKEEPER-735. cppunit test testipv6 assumes that the machine is ipv6…
0844ebe 
… enabled. (mahadev)

git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@932053 13f79535-47bb-0310-9956-ffa450edef68
@phunt
ZOOKEEPER-720. Use zookeeper-{version}-sources.jar instead of zookeep…
9899753 
…er-{version}-src.jar to publish sources in the Maven repository

git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@933101 13f79535-47bb-0310-9956-ffa450edef68
@phunt
ZOOKEEPER-722. zkServer.sh uses sh's builtin echo on BSD, behaves inc…
ee94904 
…orrectly.

git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@933110 13f79535-47bb-0310-9956-ffa450edef68
@phunt
ZOOKEEPER-741. root level create on REST proxy fails
0196b6f 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@936619 13f79535-47bb-0310-9956-ffa450edef68
@phunt
ZOOKEEPER-631. zkpython's C code could do with a style clean-up
4d47856 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@936623 13f79535-47bb-0310-9956-ffa450edef68
@phunt
ZOOKEEPER-738. zookeeper.jute.h fails to compile with -pedantic
cff0c0c 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@938194 13f79535-47bb-0310-9956-ffa450edef68
@phunt
ZOOKEEPER-734. QuorumPeerTestBase.java and ZooKeeperServerMainTest.ja…
59a3cc5 
…va do not handle windows path correctly

git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@938214 13f79535-47bb-0310-9956-ffa450edef68
@phunt
ZOOKEEPER-754. numerous misspellings "succesfully"
142e7d3 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@938710 13f79535-47bb-0310-9956-ffa450edef68
@henryr
ZOOKEEPER-749 (OSGi metadata not included in binary only jar) and ZOO…
714a4b4 
…KEEPER-750 (move maven artifacts into dist-maven subdir of the release (package target))

git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@939181 13f79535-47bb-0310-9956-ffa450edef68
@henryr
ZOOKEEPER-758. zkpython segfaults on invalid acl with missing key
9cdf11c 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@939869 13f79535-47bb-0310-9956-ffa450edef68
ZOOKEEPER-737. some 4 letter words may fail with netcat (nc) (mahadev)
01d8f73 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@941061 13f79535-47bb-0310-9956-ffa450edef68
@phunt
ZOOKEEPER-763. Deadlock on close w/ zkpython / c client
16c31c9 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@941513 13f79535-47bb-0310-9956-ffa450edef68
ZOOKEEPER-764. Observer elected leader due to inconsistent voting vie…
342b2f5 
…w (henry via mahadev)

git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@941520 13f79535-47bb-0310-9956-ffa450edef68
ZOOKEEPER-766. forrest recipes docs don't mention the lock/queue reci…
0bda251 
…pe implementations available in the release (phunt via mahadev)

git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@941525 13f79535-47bb-0310-9956-ffa450edef68
@phunt
Preparing for release 3.3.1
5c30881 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@941796 13f79535-47bb-0310-9956-ffa450edef68
@phunt
ZOOKEEPER-763. Deadlock on close w/ zkpython / c client - missed a ch…
6647c5e 
…anged file

git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@941837 13f79535-47bb-0310-9956-ffa450edef68
@phunt
ZOOKEEPER-789. Improve FLE log messages
4c85fcf 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@960675 13f79535-47bb-0310-9956-ffa450edef68
@breed
ZOOKEEPER-790. Last processed zxid set prematurely while establishing…
10a1f58 
… leadership (fpj via breed)

git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@966984 13f79535-47bb-0310-9956-ffa450edef68
@phunt
fixed version string in build.xml to be consistent with prior releases
e0e65d8 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@979473 13f79535-47bb-0310-9956-ffa450edef68
ZOOKEEPER-783. committedLog in ZKDatabase is not properly synchronize…
ce83e59 
…d (henry via mahadev)

git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@979474 13f79535-47bb-0310-9956-ffa450edef68
ZOOKEEPER-790. Last processed zxid set prematurely while establishing…
d18f029 
… leadership (flavio via mahadev)

git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@980572 13f79535-47bb-0310-9956-ffa450edef68
ZOOKEEPER-772. zkpython segfaults when watcher from async get childre…
7a699e2 
…n is invoked. (henry robinson via mahadev)

git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@984518 13f79535-47bb-0310-9956-ffa450edef68
@breed
ZOOKEEPER-795. eventThread isn't shutdown after a connection "session…
803a4c8 
… expired" event coming

git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@986470 13f79535-47bb-0310-9956-ffa450edef68
@henryr
ZOOKEEPER-792: zkpython memory leak (Lei Zhang via henryr)
f050cb8 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@987984 13f79535-47bb-0310-9956-ffa450edef68
@breed
ZOOKEEPER-785. Zookeeper 3.3.1 shouldn't infinite loop if someone cre…
c46f933 
…ates a server.0 line

git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@995844 13f79535-47bb-0310-9956-ffa450edef68
@phunt
Zookeeper 3.3.1 shouldn't infinite loop if someone creates a server.0…
68601a9 
… line (part 2)

git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@997097 13f79535-47bb-0310-9956-ffa450edef68
@phunt
ZOOKEEPER-846. zookeeper client doesn't shut down cleanly on the clos…
35ca466 
…e call

git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@999777 13f79535-47bb-0310-9956-ffa450edef68
ZOOKEEPER-804. c unit tests failing due to "assertion cptr failed" (m…
3324b33 
…ichi mutsuzaki via mahadev)

git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/branches/branch-3.3@1004845 13f79535-47bb-0310-9956-ffa450edef68
phunt and others added 6 commits July 29, 2012 05:06
@phunt
ZOOKEEPER-1521. LearnerHandler initLimit/syncLimit problems specifyin…
5c3f97d 
…g follower socket timeout limits (phunt)

git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.3@1366783 13f79535-47bb-0310-9956-ffa450edef68
@phunt
ZOOKEEPER-1493. C Client: zookeeper_process doesn't invoke completion…
01c6622 
… callback if zookeeper_close has been called (Michi Mutsuzaki via phunt and mahadev)

git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.3@1366786 13f79535-47bb-0310-9956-ffa450edef68
@phunt
Preparing for release 3.3.6
e4f7915 
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.3@1366787 13f79535-47bb-0310-9956-ffa450edef68
@henryr
ZOOKEEPER-1376. zkServer.sh does not correctly check for $SERVER_JVMF…
314a552 
…LAGS (Skye W-M via henryr)

git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.3@1388719 13f79535-47bb-0310-9956-ffa450edef68
@phunt
ZOOKEEPER-1581. change copyright in notice to 2012 (breed via phunt)
8177d4e 
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.3@1420546 13f79535-47bb-0310-9956-ffa450edef68
@phunt
ZOOKEEPER-1613. The documentation still points to 2008 in the copyrig…
ed0e217 
…ht notice (Edward Ribeiro via phunt)

git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.3@1438368 13f79535-47bb-0310-9956-ffa450edef68
@RokLenarcic RokLenarcic closed this Mar 1, 2022
@RokLenarcic RokLenarcic reopened this Mar 1, 2022
@RokLenarcic RokLenarcic closed this Mar 1, 2022
@RokLenarcic RokLenarcic reopened this Mar 1, 2022
@RokLenarcic RokLenarcic closed this Mar 1, 2022
@RokLenarcic RokLenarcic reopened this Mar 1, 2022
@RokLenarcic RokLenarcic closed this Mar 1, 2022
@RokLenarcic RokLenarcic reopened this Mar 1, 2022
@RokLenarcic RokLenarcic closed this Mar 2, 2022
@RokLenarcic RokLenarcic reopened this Mar 2, 2022
@RokLenarcic RokLenarcic closed this Mar 2, 2022
@RokLenarcic RokLenarcic reopened this Mar 2, 2022
RokLenarcic
RokLenarcic commented Mar 11, 2022
View reviewed changes
Copy link
Owner Author

@RokLenarcic RokLenarcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AA

README.txt
Comment on lines +25 to -27
zookeeper-<version>.jar - bin (binary) jar - contains only class (*.class) files
zookeeper-<version>-sources.jar - contains only src (*.java) files
zookeeper-<version>-javadoc.jar - contains only javadoc files

The bin/src/javadoc jars were added specifically to support Maven/Ivy which have the
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CS

RokLenarcic
RokLenarcic commented Mar 11, 2022
View reviewed changes
Copy link
Owner Author

@RokLenarcic RokLenarcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AA

README.txt
zookeeper-<version>-javadoc.jar - contains only javadoc files

The bin/src/javadoc jars were added specifically to support Maven/Ivy which have the
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CS

RokLenarcic
RokLenarcic commented Mar 11, 2022
View reviewed changes
Copy link
Owner Author

@RokLenarcic RokLenarcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AA

README.txt
Comment on lines +29 to +31
These bin/src/javadoc jars were added specifically to support Maven/Ivy which have
the ability to pull these down automatically as part of your build process.
The content of the legacy jar and the bin+sources jar are the same.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CS

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clojars Project

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Clojars Project
  • Clojars Project
  • Clojars Project
  • Clojars Project
  • Clojars Project
  • Clojars Project
  • Clojars Project
  • Clojars Project

@RokLenarcic RokLenarcic reopened this Mar 16, 2022
@RokLenarcic RokLenarcic reopened this Mar 25, 2022
@RokLenarcic RokLenarcic reopened this Mar 25, 2022
RokLenarcic pushed a commit that referenced this pull request Aug 31, 2022
@ztzg @RokLenarcic
ZOOKEEPER-1112: Add (Cyrus) SASL authentication support to C client l…
fb16a40 
…ibrary

This is a "respin" of apache#1054, which I withdrew due to some annoying shortcomings.

This changeset allows C clients to use SASL to authenticate with the ZooKeeper server.  It is loosely based on patches #1 and #2 by Tom Klonikowski, at https://reviews.apache.org/r/2252/, but the result has been extensively reworked to follow the semantics of the Java client:

  * No SASL operations are exposed through the API;

  * The configuration is provided, and stored, at "handle init time";

  * SASL authentication is automatically performed after each (re)connect.

It introduces an optional dependency on the Cyrus SASL library, which can either be autodetected (default) or configured using the `--without-sasl`/`--with-sasl[=DIR]` flags, or -DWITH_CYRUS_SASL for CMake/Windows.

`TestServerRequireClientSASLAuth.cc` has been renamed to `TestSASLAuth.cc`, and a test has been added which successfully (re)authenticates using the `DIGEST-MD5` mechanism.  The code has also been used to successfully authenticate clients via `GSSAPI`/Kerberos.

This commit also adds SASL support to the `cli.c` client.

Co-authored-by: Tom Klonikowski <klonik_tinformatik.haw-hamburg.de>

Author: Damien Diederen <[email protected]>

Reviewers: Mate Szalay-Beko <[email protected]>, Norbert Kalmar <[email protected]>

Closes apache#1134 from ztzg/ZOOKEEPER-1112-c-client-sasl-support-v2
RokLenarcic pushed a commit that referenced this pull request Sep 3, 2022
@ztzg @RokLenarcic
ZOOKEEPER-1112: Add (Cyrus) SASL authentication support to C client l…
f1063b3 
…ibrary

This is a "respin" of apache#1054, which I withdrew due to some annoying shortcomings.

This changeset allows C clients to use SASL to authenticate with the ZooKeeper server.  It is loosely based on patches #1 and #2 by Tom Klonikowski, at https://reviews.apache.org/r/2252/, but the result has been extensively reworked to follow the semantics of the Java client:

  * No SASL operations are exposed through the API;

  * The configuration is provided, and stored, at "handle init time";

  * SASL authentication is automatically performed after each (re)connect.

It introduces an optional dependency on the Cyrus SASL library, which can either be autodetected (default) or configured using the `--without-sasl`/`--with-sasl[=DIR]` flags, or -DWITH_CYRUS_SASL for CMake/Windows.

`TestServerRequireClientSASLAuth.cc` has been renamed to `TestSASLAuth.cc`, and a test has been added which successfully (re)authenticates using the `DIGEST-MD5` mechanism.  The code has also been used to successfully authenticate clients via `GSSAPI`/Kerberos.

This commit also adds SASL support to the `cli.c` client.

Co-authored-by: Tom Klonikowski <klonik_tinformatik.haw-hamburg.de>

Author: Damien Diederen <[email protected]>

Reviewers: Mate Szalay-Beko <[email protected]>, Norbert Kalmar <[email protected]>

Closes apache#1134 from ztzg/ZOOKEEPER-1112-c-client-sasl-support-v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RokLenarcic @phunt @henryr @breed @fpj @skamille