1. Reinstate missing imports to ZooKeeperMain.

2. Add unit tests for CommandFactory. 3. Remove redundant import from CommandFactory.
RokLenarcic · Feb 20, 2020 · 4957d89 · 4957d89
1 parent ed76f14
commit 4957d89
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 2 deletions.
diff --git a/zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeperMain.java b/zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeperMain.java
@@ -40,6 +40,9 @@
 import org.apache.zookeeper.admin.ZooKeeperAdmin;
 import org.apache.zookeeper.cli.CliCommand;
 import org.apache.zookeeper.cli.CommandFactory;
+import org.apache.zookeeper.cli.CommandNotFoundException;
+import org.apache.zookeeper.cli.CliException;
+import org.apache.zookeeper.cli.MalformedCommandException;
 import org.apache.zookeeper.client.ZKClientConfig;
 import org.apache.zookeeper.server.ExitCode;
 import org.apache.zookeeper.util.ServiceUtils;

diff --git a/zookeeper-server/src/main/java/org/apache/zookeeper/cli/CommandFactory.java b/zookeeper-server/src/main/java/org/apache/zookeeper/cli/CommandFactory.java
@@ -1,7 +1,5 @@
 package org.apache.zookeeper.cli;
 
-import org.apache.zookeeper.server.admin.Command;
-
 import java.util.function.Supplier;
 
 /**

diff --git a/zookeeper-server/src/test/java/org/apache/zookeeper/cli/CommandFactoryTest.java b/zookeeper-server/src/test/java/org/apache/zookeeper/cli/CommandFactoryTest.java
@@ -0,0 +1,20 @@
+package org.apache.zookeeper.cli;
+
+import static org.junit.Assert.assertTrue;
+import org.junit.Test;
+
+/**
+ * Unit test for {@link CommandFactory}.
+ */
+public class CommandFactoryTest {
+
+    /**
+     * Verify that the {@code CommandFactory} can create a command instance.
+     */
+    @Test
+    public void testCommandCreation() {
+        CliCommand cliCommand =
+                CommandFactory.getInstance(CommandFactory.Command.CREATE);
+        assertTrue(cliCommand instanceof CreateCommand);
+    }
+}