Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tb insert command and new placeholders #112

Merged
merged 32 commits into from
Oct 13, 2023
Merged

tb insert command and new placeholders #112

merged 32 commits into from
Oct 13, 2023

Conversation

thiagogebrimm
Copy link
Contributor

feat: add /tb insert command
feat: add %titansbattle_groups_size%" and ,"%titansbattle_participants_size% placeholders

thiagogebrimm and others added 28 commits July 15, 2022 01:53
@thiagogebrimm
webhook system in start a game
407437c
@thiagogebrimm
Correção para poder customizar a mensagem em cada evento
761d456
@thiagogebrimm
Fixed async and removed unusable imports
bd5ef3a
@thiagogebrimm
'-' fix
4faad44
@thiagogebrimm
Removed inused import
d8ac671
@thiagogebrimm
moved to the Game class
7fd4b95
@thiagogebrimm
correções a pedido do roj
2cab483
@thiagogebrimm
Merge branch 'RoinujNosde:master' into master
e9ae084
@thiagogebrimm
Removido o inutilizado da class
f77abdc
@RoinujNosde
Update language-en.yml
b9ee397
@thiagogebrimm
Removido inutilizados da class
d89a5b4
@thiagogebrimm
Removido inutilizados da class
988379c
@thiagogebrimm
Merge remote-tracking branch 'origin/master'
62e88ef
@thiagogebrimm
Removido inutilizados da class
7cd0f35
@RoinujNosde
Added args to discordAnnounce
6e62e4d
@RoinujNosde
Updated config description
09babe0
@RoinujNosde
Moved DiscordWebhook to discord package
47569f4 
Logging error messages from hook
Fixed user-agent
Replaced json.simple with gson
@thiagogebrimm
Merge branch 'RoinujNosde:master' into master
31698ce
@thiagogebrimm
Merge branch 'RoinujNosde:master' into master
e4ebb25
@thiagogebrimm
feat: added message for sending game won in Discord
b7ca103
@thiagogebrimm
Merge branch 'RoinujNosde:master' into master
dbf63fe
@thiagogebrimm
feat: added message for sending game killer in Discord
8d894f7
@thiagogebrimm
feat: added kills in message for sending game killer in Discord
6a32959
@thiagogebrimm
fix: Fixed killer kill counter in discord message
f2cd360
@thiagogebrimm
Merge branch 'RoinujNosde:master' into master
ad13856
@thiagogebrimm
Update nbt-api for works in 1.20
fb3405f
@thiagogebrimm
Merge branch 'RoinujNosde:master' into master
579b6b6
@thiagogebrimm
feat: add /tb insert command
a3adc47 
feat: add %titansbattle_groups_size%" and ,"%titansbattle_participants_size% placeholders
@RoinujNosde
Copy link
Owner

Seria melhor separar os placeholders em outra PR.

RoinujNosde
RoinujNosde requested changes Oct 1, 2023
View reviewed changes
Copy link
Owner

@RoinujNosde RoinujNosde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Separe as mudanças em diferentes PRs.
  • A solução usando o método estático isInsertCalled não é muito boa. Recomendo adicionar um novo método similar ao onJoin(), talvez onLateJoin().

@thiagogebrimm
Copy link
Contributor Author

  • Separe as mudanças em diferentes PRs.
  • A solução usando o método estático isInsertCalled não é muito boa. Recomendo adicionar um novo método similar ao onJoin(), talvez onLateJoin().

Essa PR agora é só as placeholders, vou refazer o insert depois

@RoinujNosde RoinujNosde merged commit fdb86ec into RoinujNosde:master Oct 13, 2023
1 check passed
@bot-wolf bot-wolf mentioned this pull request Oct 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SrBedrock SrBedrock SrBedrock left review comments

@RoinujNosde RoinujNosde RoinujNosde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thiagogebrimm @RoinujNosde @SrBedrock