Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mj.6884 input max min length #1353

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Conversation

micahjones13
Copy link
Collaborator

Brief Description

This PR adds minlength and maxlength props to rux-input. It also adds tests and updates the story page to include the new props.

JIRA Link

https://rocketcom.atlassian.net/browse/ASTRO-6884

Related Issue

General Notes

Motivation and Context

Issues and Limitations

Types of changes

  • Bug fix
  • New feature
  • Breaking change

Checklist

  • This PR adds or removes a Storybook story.
  • I have added tests to cover my changes.
  • Regressions are passing and/or failures are documented
  • Changes have been checked in evergreen browsers

Copy link

changeset-bot bot commented Oct 18, 2024

🦋 Changeset detected

Latest commit: a193b5b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for astro-stencil ready!

Name Link
🔨 Latest commit a193b5b
🔍 Latest deploy log https://app.netlify.com/sites/astro-stencil/deploys/671284d80f4d8b0008a9e531
😎 Deploy Preview https://deploy-preview-1353--astro-stencil.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for astro-preview ready!

Name Link
🔨 Latest commit a193b5b
🔍 Latest deploy log https://app.netlify.com/sites/astro-preview/deploys/671284d8fc200d0008d69aa9
😎 Deploy Preview https://deploy-preview-1353--astro-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@kiley-mitti kiley-mitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my hero :)

@micahjones13 micahjones13 merged commit 44237a2 into main Oct 18, 2024
7 checks passed
@micahjones13 micahjones13 deleted the mj.6884-input-max-min-length branch October 18, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants