Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing api docs #1185

Merged
merged 1 commit into from
Jul 20, 2023
Merged

fix: missing api docs #1185

merged 1 commit into from
Jul 20, 2023

Conversation

markacianfrani
Copy link
Contributor

Brief Description

adds docs for a few missing APIs due to the most insignificant issue on the planet. doc block decs need to be above @component

JIRA Link

Related Issue

General Notes

Motivation and Context

Issues and Limitations

Types of changes

  • Bug fix
  • New feature
  • Breaking change

Checklist

  • This PR adds or removes a Storybook story.
  • I have added tests to cover my changes.
  • Regressions are passing and/or failures are documented
  • Changes have been checked in evergreen browsers

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2023

⚠️ No Changeset found

Latest commit: 1e12bb0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for astro-preview ready!

Name Link
🔨 Latest commit 1e12bb0
🔍 Latest deploy log https://app.netlify.com/sites/astro-preview/deploys/64b8012b55d919000898214d
😎 Deploy Preview https://deploy-preview-1185--astro-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for astro-stencil ready!

Name Link
🔨 Latest commit 1e12bb0
🔍 Latest deploy log https://app.netlify.com/sites/astro-stencil/deploys/64b8012b6aba4e0008b9f2ff
😎 Deploy Preview https://deploy-preview-1185--astro-stencil.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@markacianfrani markacianfrani merged commit 4f8f8c1 into main Jul 20, 2023
6 of 7 checks passed
@markacianfrani markacianfrani deleted the mc.api-docs-fix branch July 20, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants