-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mj.dual range slider #1148
Mj.dual range slider #1148
Conversation
🦋 Changeset detectedLatest commit: c832fe6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-stencil ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for astro-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
packages/web-components/src/components/rux-slider/rux-slider.tsx
Outdated
Show resolved
Hide resolved
I can't for the life of me get the click to work in testing for moving the right thumb. Using the same method as I did to move the left thumb, but as soon as position y gets over 20 it breaks. I tried |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful! Needs a changes but looks amazing. Great job Micah! It's brilliant. :)
I was testing programmatically updating the minVal and value prop and I noticed that the way the thumbs are set in the test file is with an attribute called |
ah great catch, that's a vestige of the first implementation. I'll fix that right now. Thank you!! |
…sInc/astro into mj.dual-range-slider
Brief Description
Adds dual-range capabilities to our rux-slider.
Refactors some of the markup and styles in order to be simpler and better match design.
datalist
outside of therux-slider
div.New Props
JIRA Link
https://rocketcom.atlassian.net/browse/ASTRO-6206
Related Issue
#1073
General Notes
Currently, the bar between the thumbs in dual-range is not clickable/intractable. This is pending some more design research and could be changed in the future, but we left it out to prevent having to make a breaking change if the research says it shouldn't be clicked.
Motivation and Context
Adds dual-range variant to slider.
Dual-range has been an ask from clients.
Issues and Limitations
Dual range by default can have the thumbs swap over each other, and this can create instances where
min-val
is higher thanvalue
. A ticket has been made for this, but it is non-blocking for MVP.Types of changes
Checklist