Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(react): fix/update docs #1115

Merged
merged 1 commit into from
Apr 20, 2023
Merged

docs(react): fix/update docs #1115

merged 1 commit into from
Apr 20, 2023

Conversation

micahjones13
Copy link
Collaborator

Brief Description

Our React docs had an incorrect example in the testing section. Also, the link to the test app repo at the bottom of the React docs page in now incorrect since that test repo has been removed in recent versions. The link now points to 7.7, which has the test repo.

JIRA Link

Related Issue

#1114

General Notes

We'll need to do a SB publish for this to go live.

Motivation and Context

User noticed syntax error in code examples.
Test app repo couldn't be easily found.

Issues and Limitations

Types of changes

  • Bug fix
  • New feature
  • Breaking change

Checklist

  • This PR adds or removes a Storybook story.
  • I have added tests to cover my changes.
  • Regressions are passing and/or failures are documented
  • Changes have been checked in evergreen browsers

@changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2023

⚠️ No Changeset found

Latest commit: 370f3ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Apr 17, 2023

Deploy Preview for astro-stencil ready!

Name Link
🔨 Latest commit 370f3ec
🔍 Latest deploy log https://app.netlify.com/sites/astro-stencil/deploys/643db9718a5b7a000809ba36
😎 Deploy Preview https://deploy-preview-1115--astro-stencil.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 17, 2023

Deploy Preview for astro-preview ready!

Name Link
🔨 Latest commit 370f3ec
🔍 Latest deploy log https://app.netlify.com/sites/astro-preview/deploys/643db97187a2d600082e0c71
😎 Deploy Preview https://deploy-preview-1115--astro-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@kiley-mitti kiley-mitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :)

@micahjones13 micahjones13 merged commit b31ed13 into main Apr 20, 2023
@micahjones13 micahjones13 deleted the mj-react-docs branch April 20, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants