fix(eslint): Add missing ESLint rule for TypeScript (#470)

RocketChat · Jun 16, 2021 · cc0d498 · cc0d498
1 parent e393d98
commit cc0d498
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/packages/eslint-config-alt/typescript/index.js b/packages/eslint-config-alt/typescript/index.js
@@ -18,6 +18,7 @@ module.exports = {
         argsIgnorePattern: '^_',
       },
     ],
+    '@typescript-eslint/no-use-before-define': ['error'],
     'func-call-spacing': 'off',
     'indent': 'off',
     'import/order': [

diff --git a/packages/fuselage/src/components/Message/Metrics/index.tsx b/packages/fuselage/src/components/Message/Metrics/index.tsx
@@ -11,12 +11,6 @@ const ContentItem: FC = (props) => (
   <div className='rcx-message-metrics__content-item' {...props} />
 );
 
-export const Reply: FC<ComponentProps<typeof Button>> = (props) => (
-  <MetricsItem>
-    <Button {...props} {...{ small: true, primary: true }} />
-  </MetricsItem>
-);
-
 type IconProps = { name: 'thread' | 'user' | 'clock' | 'discussion' };
 type FollowingProps = { name: 'bell' | 'bell-off' };
 
@@ -47,6 +41,12 @@ const MetricsFollowing: FC<FollowingProps> = ({ name }) => (
   />
 );
 
+export const Reply: FC<ComponentProps<typeof Button>> = (props) => (
+  <MetricsItem>
+    <Button {...props} {...{ small: true, primary: true }} />
+  </MetricsItem>
+);
+
 Metrics.Reply = Reply;
 
 Metrics.Item = MetricsItem;

diff --git a/packages/message-parser/src/utils.ts b/packages/message-parser/src/utils.ts
@@ -22,11 +22,6 @@ export const color = (r: number, g: number, b: number, a = 255): Color => ({
   value: { r, g, b, a },
 });
 
-export const emoji = (() => {
-  const fn = generate('EMOJI');
-  return (value: string) => fn(plain(value));
-})();
-
 export const heading = (
   value: Heading['value'],
   level: Heading['level'] = 1
@@ -89,6 +84,11 @@ export const mentionUser = (() => {
   return (value: string) => fn(plain(value));
 })();
 
+export const emoji = (() => {
+  const fn = generate('EMOJI');
+  return (value: string) => fn(plain(value));
+})();
+
 export const reducePlainTexts = (
   values: Paragraph['value']
 ): Paragraph['value'] =>