Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Informal German translations #9984

Merged
merged 3 commits into from
Sep 10, 2018

Conversation

mrsimpson
Copy link
Collaborator

  • Address users in an informal way
    Liebe Deutsche 🇩🇪 Anwender, wir kennen euch nun besser. Ab sofort wollen wir "Du" zu einander sagen
  • Harmonize texts for "private Kanäle" / "Private Gruppen" => Always translate to "Kanäle"

@kaiiiiiiiii
Copy link
Contributor

kaiiiiiiiii commented Mar 2, 2018

Please add a second language option for that.

@mrsimpson
Copy link
Collaborator Author

@marceloschmidt we discussed this quite some time ago. Just seen the PR is still open.
I understand @kaiiiiiiiii 's concern about informalizing. However, I recall you wanted to have the informal one. I could also move the contents of these files to another language file, but you should decide what the default is: formal or informal?

@marceloschmidt
Copy link
Member

When I think about formal vs informal in Portuguese, formal Portuguese sounds very inadequate for a software, while informal Portuguese may sound as poorly built, so we use a mix between the two, whatever "sounds" best. I say use your best judgement. Does formal sound too weird in that context? If so, try less formal... in Portuguese, we use a lot of English words, because translating them would be very weird, such as "Online" and "Logout" for example.

@mrsimpson
Copy link
Collaborator Author

@marceloschmidt in German, the differentiation is not as huge. It's mainly a formal article for "you".
I believe having two locales is in possible in general, though maintenance is of course a pain. Or are there include-mechanisms which would just allow the texts containing a "you" to be overwritten?

@kaiiiiiiiii
Copy link
Contributor

kaiiiiiiiii commented Jun 20, 2018

@mrsimpson It’s may a pain in the arse to have two german translations, but we use RC in an enterprise environment and we definitely don’t want to use informal german on our installation :)

And it’s not just about the “You”. Sometimes the hole structure of a sentence can change when you use formal/informal german.

@mrsimpson
Copy link
Collaborator Author

@kaiiiiiiiii Finally, I managed to provide a second language option for informal german in Rocket.Chat (with TAPi18n as translation framework) 🎉
TAPi18n refers to the IETF language tag specification. In there, the following is stated:

Optional variant subtags, separated by hyphens, each composed of five to eight letters, or of four characters starting with a digit; (Variant subtags are registered with IANA and not associated with any external standard.)

However, at least on my local build, the language variant is not accepted in TAPi18n! I could use some help from the TAPi18n-warriors around here (looking at you, @sampaiodiego ;) )

@mrsimpson mrsimpson changed the title [BREAK] Informal German translations [NEW] Informal German translations Aug 31, 2018
@sampaiodiego
Copy link
Member

that's cool. we have to check if lingohub also supports language variations like this.

@mrsimpson
Copy link
Collaborator Author

Yup, also thought about Lingohub. But even if it didn’t: there are other (direct) ways of contributing to the informal translations.

Sent with GitHawk

The IETF language specification compliant suffix "informal"  did not work with the i18n library used
@mrsimpson
Copy link
Collaborator Author

@sampaiodiego I fought some more fights with TAPi18n - and kind of lost: I could not get it accept the IETF compliant language name de-DE-informal.
The I played it dirty and invented a non-existent, but syntactically accepted language code de-IN. This way, TAPi18n and the above layers finally accept the language files. 🎉
I don't really like this, but neither the end user should ever notice nor should other libs and tools like Lingohub trouble it.
If you accept: would you be so kind to merge it?

@sampaiodiego
Copy link
Member

all my fights against TAPi18n ended as lost 😢

I'll give it a try and merge it 😉

@sampaiodiego sampaiodiego merged commit 4378a11 into RocketChat:develop Sep 10, 2018
mrsimpson added a commit to assistify/Rocket.Chat that referenced this pull request Sep 11, 2018
* Provide a dedicated informal german language option

* Use a "virtual" language code de-IN for informal german
The IETF language specification compliant suffix "informal"  did not work with the i18n library used
This was referenced Sep 28, 2018
@mrsimpson mrsimpson deleted the informal-german branch December 7, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants