Regression: Misplaced language dropdown in user preferences panel #9883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent because all the other dropdowns in Rocket.Chat work like that.
rodrigok
changed the title
|
You can set
|
|
@karlprieb but is it supposed to look different from all the other dropdowns in the user preferences ui?
|
|
@kaiiiiiiiii no, the other ones are wrong. We didn't updated this page. You can fix that if you want changing all selects to be equal to the language selector. |
|
@karlprieb As far as I can see there's only one other dropdown which is tagged with the Anyway, can you may approve this PR to get a working solution for release 0.62.0 (same look as in 0.61.2) and I'll open another PR which changes all dropdowns in RC? Because there's also a 2px cut off at the bottom, which needs to be fixed first.
|
|
@kaiiiiiiiii Sure! |
karlprieb
approved these changes
Feb 26, 2018
kaiiiiiiiii
deleted the
fix_misplaced_language_dropdown_in_user_preferences_panel
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #9882
Looks like all the other dropdowns in Rocket.Chat again :)
Before:
After:
