[FIX] Verified property of user is always set to false if not supplied #9719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it was setting always to false.
|
Added a new endpoint to prevent any breaking change, which might happen if we modified the |
rodrigok
requested changes
Mar 8, 2018
| @@ -167,7 +167,9 @@ RocketChat.saveUser = function(userId, userData) { | |||
| updateUser.$set.requirePasswordChange = userData.requirePasswordChange; | |||
| } | |||
|
|
|||
| updateUser.$set['emails.0.verified'] = !!userData.verified; | |||
| if (userData.verified) { | |||
| updateUser.$set['emails.0.verified'] = true; | |||
There was a problem hiding this comment.
Can't I set as not verified? Shouldn't be more correct to check if userData.verified is boolean and then allow to change, that way we do not require to pass that information but allow admins to revert some mistake.
| userData.typedPassword = SHA256(this.bodyParams.data.actualPassword); | ||
| } | ||
|
|
||
| Meteor.runAsUser(this.bodyParams.userId, () => Meteor.call('saveUserProfile', userData, this.bodyParams.customFields)); |
There was a problem hiding this comment.
That way you are allowing anyone to change other's user information, should run as the authenticated user
| email: Match.Maybe(String), | ||
| name: Match.Maybe(String), | ||
| username: Match.Maybe(String), | ||
| actualPassword: Match.Maybe(String), |
There was a problem hiding this comment.
Wouldn't be better currentPassword rather than actualPassword ?
…ificationEmail method
rodrigok
changed the title
rodrigok
approved these changes
Mar 9, 2018
rodrigok
added a commit
that referenced
this pull request
Mar 9, 2018
…update [FIX] Verified property of user is always set to false if not supplied
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #9718
Added verification before update the user, because was being setting
verifiedproperty always to false, if was not supplied.