[FIX] Missing string 'Username_already_exist' on the accountProfile page #9610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
graywolf336
suggested changes
Feb 6, 2018
| @@ -2030,6 +2030,7 @@ | |||
| "Username_is_already_in_here": "`@%s` is already in here.", | |||
| "Username_is_not_in_this_room": "The user `#%s` is not in this room.", | |||
| "Username_Placeholder": "Please enter usernames...", | |||
| "Username_already_exist": "Username already exists. Please take some other name.", | |||
There was a problem hiding this comment.
Can we change it to "Username already exists. Please try another username."? I believe that makes more sense.
lunaticmonk
force-pushed
the
missing-string
branch
from
dfecb58
to
ba8e342
Compare
lunaticmonk
force-pushed
the
missing-string
branch
from
ba8e342
to
4d2f450
Compare
|
@graywolf336 Please review. |
graywolf336
approved these changes
Feb 8, 2018
rodrigok
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Fixes #9494