-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Modal #9092
[NEW] Modal #9092
Changes from 8 commits
9534141
ba7118d
2c8a74a
10d7557
a0157a5
fff30c2
f89302e
271f0d7
083eba2
e7576b9
8eb06ae
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -236,7 +236,6 @@ [email protected] | |
[email protected] | ||
[email protected] | ||
simple:[email protected] | ||
smoral:[email protected] | ||
[email protected] | ||
[email protected] | ||
[email protected] | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
/* globals LivechatVideoCall, Livechat */ | ||
/* globals LivechatVideoCall, Livechat, swal */ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is it still needed to add swal to globals when actually removing it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Livechat widget still uses sweetAlert There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 makes sense I just saw the adding in a bunch of files so was checking :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
// Functions to call on messages of type 'command' | ||
this.Commands = { | ||
survey() { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
/* globals swal */ | ||
|
||
Template.survey.events({ | ||
'click button.skip'(e, instance) { | ||
instance.$('#survey').remove(); | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be aligned with the others?