Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provides "Do Not Disturb" and "Snooze Notifications" #8806

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from

Conversation

lindoelio
Copy link
Contributor

@lindoelio lindoelio commented Nov 7, 2017

@RocketChat/core

Closes RocketChat/feature-requests#803
Closes #2143
Closes #6418

Provides ability to mute notifications for a time period ("do not disturb" and "snooze notifications") covering both features either on "application level" (for any notifications from all chat subscriptions) or on "channel/room level" (include direct messages subscriptions).

"Do Not Disturb" and "Snooze Notifications" on application level are options available on user's notifications/messages preferences (snoozing all notifications addressed to user, from whatever subscriptions). In addition, this features also can "do not disturb" and/or "snooze notifications" on specific channels (and also shall be combined with behavior defined for "application level").

Setting "Do Not Disturb" and "Snooze Notifications" on Application Level
image

Setting "Do Not Disturb" and "Snooze Notifications" on Channel Level
image

image

image

image

@sampaiodiego
Copy link
Member

sampaiodiego commented Nov 7, 2017

I think the "Do Not Disturb" feature makes more sense on application level (instead of room level). Let's say I'm using Rocket.Chat for work, so I would like to not be disturbed in any room on whole server, and not have to set the same thing on each channel I'm in.

the snooze feature I can see using both application and room levels. but having per room I think it's ok =)

awesome features btw.. thank you

@rodrigok
Copy link
Member

rodrigok commented Nov 7, 2017

I agree with @sampaiodiego do not disturb should be an application level and ask user how long to stay (like the snooze but with one option forever, that eliminates the snooze option)

The same could be made to the room level, but we should call it as mute where you could mute for a certain period of time or forever, like whatsapp does

What do you think?

@graywolf336
Copy link
Contributor

Question - what timezone are the times set in? Are they UTC or the user's timezone?

@lindoelio
Copy link
Contributor Author

lindoelio commented Nov 7, 2017

@sampaiodiego and @rodrigok
I should explain better about this features; I will do this on PR description for better comprehension from all guys.

In true, this current PR already covers both features either on "application level" or "channel/room level". So, "Do Not Disturb" feature already works for mute any notifications on a Rocket.Chat instance for that user (who can setup this on yours Notifications/Messagens preferences - that come off by default), besides works also on channel level granularity (combined with user settings for "application level" at the same time). It's exactly what you think that it should be :-)

"Do Not Disturb" and "Snooze Notifications" features also works fine together with implements already merged for mute/hide notifications on our current release, in both granularity level (global/application and channels/rooms).

@graywolf336
It shall set the user's timezone. In this case, moment works on instance's server side for set and get.

I'm waiting for your heavy code review :-P I (and a lot of people on our community) would love see this merged soon!

Thanks for your feedback!

@lindoelio
Copy link
Contributor Author

Closing for a while... Working on how long to stay "do not disturb" feature, as suggested.

@lindoelio lindoelio closed this Nov 13, 2017
@rodrigok rodrigok modified the milestones: 2.2.0, 2.3.0 Oct 18, 2019
@tassoevan
Copy link
Contributor

Some considerations to refresh this pull request:

  1. sendNotificationsOnMessage was deeply modified, specially the afterSaveMessage callback;
  2. pushNotificationsFlexTab layout changed a lot, so we need a design review comparing older and newer versions;
  3. Other conflicts have easy resolutions.

@pjv
Copy link

pjv commented Dec 26, 2019

Please, please figure out how to get this PR merged. DING DING DING.

@samtuke
Copy link

samtuke commented Feb 11, 2020

We'd also love to see this feature implemented on RocketChat hosted

@sveatlo
Copy link

sveatlo commented May 10, 2020

Please, merge this. It's (at least from our perspective) the most important function for a chat application used in a workspace.

@majklovec
Copy link

majklovec commented Jun 24, 2020

This is really needed in our company, could you please merge that?

@mariohamann
Copy link

+1
Please add this one!

@dupinka
Copy link

dupinka commented Jun 25, 2020

I agree, please add this, this would be extremely useful for our company.

@lequy1010
Copy link

lequy1010 commented Jul 15, 2020

That's a good function.
I think do not disturb should be an room level, because when i have lots of room and i want to don't disturb from some room.

@rcerrejon
Copy link

no plans to add this feature?

@dancorrigan1
Copy link

Much requested feature from my internal users. +1

@nedvedad
Copy link

Our team members request this feature almost on daily basis. Implementation would be very much appreciated.

@dusatvoj
Copy link

@nedvedad One of the features which is needed AF but it probably will never be merged (bcs there's a lot of changes in master) 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet