Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Scrollbar not using new style #8190

Merged
merged 4 commits into from
Sep 20, 2017
Merged

[FIX] Scrollbar not using new style #8190

merged 4 commits into from
Sep 20, 2017

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Sep 18, 2017

applied on sidenav and room

@RocketChat/core

Closes #8049

applied sidenav and room
@ggazzo ggazzo changed the title perfect scrollbar [WIP] perfect scrollbar Sep 18, 2017
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-8190 September 18, 2017 17:08 Inactive
@karlprieb
Copy link
Contributor

karlprieb commented Sep 18, 2017

@ggazzo Could you use NPM module instead Meteor packages?

@ggazzo
Copy link
Member Author

ggazzo commented Sep 18, 2017

yes I can , but I won't <3

@engelgabriel engelgabriel added this to the 0.60.0 milestone Sep 18, 2017
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-8190 September 18, 2017 20:37 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-8190 September 18, 2017 21:43 Inactive
@ggazzo
Copy link
Member Author

ggazzo commented Sep 18, 2017

@MartinSchoeler could you see the error plz? :)

@engelgabriel engelgabriel modified the milestones: 0.60.0, 0.59.0-rc.7 Sep 19, 2017
@ggazzo
Copy link
Member Author

ggazzo commented Sep 20, 2017

thanks @rodrigok

@rodrigok rodrigok changed the title [WIP] perfect scrollbar [FIX] Scrollbar not using new style Sep 20, 2017
@rodrigok rodrigok merged commit 62aad03 into develop Sep 20, 2017
@rodrigok rodrigok deleted the scroll branch September 20, 2017 12:21
rodrigok added a commit that referenced this pull request Sep 20, 2017
[FIX] Scrollbar not using new style
@cyclops24
Copy link
Contributor

@ggazzo , @karlprieb , @rodrigok Please visit above issue. ( #8223 )

@rodrigok
Copy link
Member

@cyclops24 It was my fault, the PR was in progress and with test erros, so I fixed the tests and thought was the reason to be in progress, so I merged it.

I created a new PR (#8244) disabling the scrollbar implementation and @ggazzo will finish the implementation in another PR.

Thanks by your review 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] Make scrollbar more visible using JS
5 participants