-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Configurable Volume for Notifications #6087 #7517
Merged
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1fd5b9f
Setting user preferences so notifications volume.
lindoelio 145ec7c
Internal package for notifications sound volume control UI.
lindoelio fc0df6c
Solving eslint problems for improve pull request quality.
lindoelio 4c3124c
Merge remote-tracking branch 'upstream/develop' into develop
lindoelio 5d09a50
Merge remote-tracking branch 'upstream/develop' into develop
lindoelio 5ab0702
Merge remote-tracking branch 'upstream/develop' into develop
lindoelio e309670
Implementing the administration setting for the frequency of notifica…
lindoelio 9635a06
Removing code of #2995 mistakenly included in #6087.
lindoelio 1829aa8
Merge remote-tracking branch 'upstream/develop' into develop
lindoelio dadde15
Removing code of #2995 mistakenly included in #6087.
lindoelio a95087b
Removing code of #2995 mistakenly included in #6087.
lindoelio 5ae0f43
Solving requested changes by rodrigok and karlprieb at PR #7517
lindoelio f269229
Solving requested changes by rodrigok and karlprieb at PR #7517
lindoelio 48cad72
Solving requested changes by rodrigok at PR #7517
lindoelio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,6 +36,7 @@ | |
.env | ||
.externalToolBuilders | ||
.idea | ||
.vscode | ||
.loadpath | ||
.map | ||
.metadata | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,7 +105,7 @@ [email protected] | |
[email protected] | ||
[email protected] | ||
[email protected] | ||
ostrio:[email protected].1 | ||
ostrio:[email protected].2 | ||
pauli:[email protected] | ||
pauli:[email protected] | ||
percolate:[email protected] | ||
|
@@ -203,6 +203,7 @@ rocketchat:[email protected] | |
rocketchat:[email protected] | ||
rocketchat:[email protected] | ||
rocketchat:[email protected] | ||
rocketchat:[email protected] | ||
rocketchat:[email protected] | ||
rocketchat:[email protected] | ||
rocketchat:[email protected] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
Package.describe({ | ||
name: 'rocketchat:slider', | ||
version: '0.0.1', | ||
summary: 'UI slider component for input range.', | ||
git: '', | ||
documentation: 'README.md' | ||
}); | ||
|
||
Package.onUse(function(api) { | ||
api.use('ecmascript'); | ||
api.use('templating', 'client'); | ||
api.use('rocketchat:theme'); | ||
|
||
api.addFiles('rocketchat-slider.html', 'client'); | ||
api.addFiles('rocketchat-slider.js', 'client'); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
<template name="slider"> | ||
<div class="range-slider"> | ||
<input class="range-slider-range tertiary-background-color" type="range" id="{{id}}" value="{{value}}" min="{{min}}" max="{{max}}"> | ||
<span class="range-slider-value" id="{{id}}_value"></span> | ||
</div> | ||
</template> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
Template.slider.onRendered(function() { | ||
const params = this.data; | ||
|
||
const rangeSlider = function() { | ||
|
||
const range = $(`#${ params.id }`); | ||
const labelValue = $(`#${ params.id }_value`); | ||
|
||
labelValue.html(params.value); | ||
|
||
range.on('input', function() { | ||
labelValue.html(this.value); | ||
}); | ||
}; | ||
|
||
rangeSlider(); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
.range-slider { | ||
margin: 0; | ||
width: 100%; | ||
} | ||
|
||
.range-slider-range { | ||
appearance: none; | ||
width: calc(100% - 73px); | ||
height: 10px; | ||
border-radius: 5px; | ||
outline: none; | ||
padding: 0; | ||
margin: 0; | ||
} | ||
|
||
.range-slider-range::-webkit-slider-thumb { | ||
appearance: none; | ||
width: 20px; | ||
height: 20px; | ||
border-radius: 50%; | ||
cursor: pointer; | ||
transition: background 0.15s ease-in-out; | ||
} | ||
|
||
.range-slider-range::-moz-range-thumb { | ||
width: 20px; | ||
height: 20px; | ||
border: 0; | ||
border-radius: 50%; | ||
cursor: pointer; | ||
transition: background 0.15s ease-in-out; | ||
} | ||
|
||
.range-slider-value { | ||
display: inline-block; | ||
position: relative; | ||
width: 60px; | ||
line-height: 20px; | ||
text-align: center; | ||
border-radius: 3px; | ||
padding: 5px 10px; | ||
margin-left: 8px; | ||
} | ||
|
||
.range-slider-value::after { | ||
position: absolute; | ||
top: 8px; | ||
left: -7px; | ||
width: 0; | ||
height: 0; | ||
border-top: 7px solid; | ||
border-right: 7px solid; | ||
border-bottom: 7px solid; | ||
content: ''; | ||
} | ||
|
||
.range-slider-range::-moz-range-track, | ||
.range-slider-range::-moz-focus-inner, | ||
.range-slider-range::-moz-focus-outer { | ||
border: 0; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,4 +5,4 @@ | |
@import 'imports/forms.css'; | ||
@import 'imports/base.css'; | ||
@import 'imports/rtl.css'; | ||
|
||
@import 'imports/slider.css'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check the properties here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked!