Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #616 - Fixed multiline code block overflow #674

Merged
merged 2 commits into from
Sep 3, 2015
Merged

Issue #616 - Fixed multiline code block overflow #674

merged 2 commits into from
Sep 3, 2015

Conversation

rodrigogs
Copy link
Contributor

No description provided.

@rodrigok
Copy link
Member

rodrigok commented Sep 3, 2015

Why not just override hljs class adding 1 rule instead creating a new class copying all rules?

.hljs {
    overflow-y: hidden;
}

@rodrigogs
Copy link
Contributor Author

Because overflow hidden behaviour is different from no overflow. In this case overflow hidden also solves the problem, but I think that to have no overflow at all is a better option to prevent another possible problems.

@rodrigok
Copy link
Member

rodrigok commented Sep 3, 2015

@rodrigogs according to http://www.w3schools.com/cssref/pr_pos_overflow.asp the default value of overflow is visible, so if you want to remove the overflow you can override with the value visible right?

@rodrigogs
Copy link
Contributor Author

You are right. I were trusting in what I've heard from another developers, as I never aimed for front styling. Strange to hear the same wrong thing from a bunch of people that works just with this.

@rodrigok
Copy link
Member

rodrigok commented Sep 3, 2015

Nice :D

rodrigok added a commit that referenced this pull request Sep 3, 2015
Issue #616 - Fixed multiline code block overflow
@rodrigok rodrigok merged commit eed855d into RocketChat:master Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants