Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when setting readonly room as default room #4422

Merged

Conversation

alexbrazier
Copy link
Contributor

@alexbrazier alexbrazier commented Sep 22, 2016

@RocketChat/core

Closes #4405
Probably also closes #825 as this is now done

  • Fix bug to mute users in default read only channels
  • Show muted icon in members list to easily spot who is muted (already half implemented)

image

@alexbrazier
Copy link
Contributor Author

Any ideas why the build keeps on failing when building rocketchat:cas?

rocketchat:cas: updating npm dependencies -- cas...

   Building package rocketchat:autolinker    \

   Building package rocketchat:cas           \

   Building package rocketchat:cas           \

   Building package rocketchat:cas           \

   Building package rocketchat:cas           \

Just logs Building package rocketchat:cas until it errors.

Seems to be doing it in general (nothing to do with these code changes)

@graywolf336
Copy link
Contributor

graywolf336 commented Sep 23, 2016

@alexbrazier I haven't tested it out, but what does the chat box to type in look like when you're muted? I think it'd be nice if the chat box became disabled and the placeholder/text in it became "Chatting disabled, you have been muted." and the user couldn't type of click any of the buttons to do any actions.

@engelgabriel any idea why the build is failing in travis?

@alexbrazier
Copy link
Contributor Author

Seems the build is now passing.
@graywolf336 this is what it looks like when you are muted in a read only room:
image

@Lucky21110
Copy link

Is it already committed into the development or 41?

@engelgabriel engelgabriel added this to the 0.42.0 milestone Sep 28, 2016
@engelgabriel engelgabriel merged commit f7e985f into RocketChat:develop Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readonly default channels Create room permissions for read-only / speak
5 participants