regression: UserAvatar should always render BaseAvatar

[dougfabris]

Proposed changes (including videos or screenshots)

Introduced here: #32906

Previously we didn't check userId or username to render BaseAvatar, neither throw an Error. There are some cases that username can be undefined such as ComposerBoxPopupUser which will break the entire UI if we keep the current solution.

The PR aims to not throw an Error for now, until we fix the issue causing the undefined value on ComposerBoxPopupUser

Issue(s)

Steps to test or reproduce

Further comments

CORE-834

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: d99cf5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34061/
on branch gh-pages at 2024-11-28 15:59 UTC

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.75%. Comparing base (97edecc) to head (d99cf5c).
Report is 4 commits behind head on release-7.1.0.

Additional details and impacted files

@@              Coverage Diff               @@
##           release-7.1.0   #34061   +/-   ##
==============================================
  Coverage          75.75%   75.75%           
==============================================
  Files                510      510           
  Lines              22078    22078           
  Branches            5387     5387           
==============================================
  Hits               16726    16726           
  Misses              4706     4706           
  Partials             646      646           

Flag	Coverage Δ
unit	75.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.