Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: Update and notify subscriptions on contact name update #33939

Merged
merged 20 commits into from
Nov 26, 2024
Merged

regression: Update and notify subscriptions on contact name update #33939

merged 20 commits into from
Nov 26, 2024

Conversation

matheusbsilva137
Copy link
Member

@matheusbsilva137 matheusbsilva137 commented Nov 11, 2024 •
edited by dougfabris
Loading

Proposed changes (including videos or screenshots)

Introduced here: #32727

  • Update subscriptions and inquiries when a contact name is updated;
  • Notify changes whenever a contact name is updated (so that the UI is updated accordingly without having to refresh the page).

Issue(s)

Steps to test or reproduce

Further comments

SCI-160

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Nov 11, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: dba3a18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@matheusbsilva137 matheusbsilva137 added this to the 7.1.0 milestone Nov 11, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 75.75%. Comparing base (49b90eb) to head (dba3a18).
Report is 4 commits behind head on release-7.1.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.1.0   #33939      +/-   ##
=================================================
- Coverage          75.79%   75.75%   -0.04%     
=================================================
  Files                510      510              
  Lines              22063    22078      +15     
  Branches            5385     5387       +2     
=================================================
+ Hits               16723    16726       +3     
- Misses              4694     4706      +12     
  Partials             646      646
Flag Coverage Δ
unit 75.75% <20.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review November 12, 2024 12:52
@matheusbsilva137 matheusbsilva137 requested review from a team as code owners November 12, 2024 12:52
KevLehman
KevLehman requested changes Nov 12, 2024
View reviewed changes
apps/meteor/app/lib/server/lib/notifyListener.ts Outdated Show resolved Hide resolved
apps/meteor/app/lib/server/lib/notifyListener.ts Outdated Show resolved Hide resolved
apps/meteor/server/models/raw/LivechatRooms.ts Outdated Show resolved Hide resolved
MarcosSpessatto
MarcosSpessatto previously requested changes Nov 12, 2024
View reviewed changes
apps/meteor/app/lib/server/lib/notifyListener.ts Outdated Show resolved Hide resolved
apps/meteor/server/models/raw/Subscriptions.ts Outdated Show resolved Hide resolved
apps/meteor/server/models/raw/Subscriptions.ts Outdated Show resolved Hide resolved
@matheusbsilva137 matheusbsilva137 marked this pull request as draft November 13, 2024 12:42
@dougfabris dougfabris force-pushed the feat/single-contact-id branch from 27d069f to f49e5da Compare November 13, 2024 22:03
Base automatically changed from feat/single-contact-id to develop November 19, 2024 19:30
@matheusbsilva137 matheusbsilva137 force-pushed the chore/contact-name-update branch from d15b010 to d10f9f8 Compare November 19, 2024 22:33
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33939/
on branch gh-pages at 2024-11-25 18:25 UTC

@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review November 20, 2024 00:33
@matheusbsilva137 matheusbsilva137 force-pushed the chore/contact-name-update branch from 8a0ccff to af98fc0 Compare November 21, 2024 14:51
@matheusbsilva137 matheusbsilva137 requested a review from a team as a code owner November 21, 2024 14:51
@matheusbsilva137 matheusbsilva137 changed the base branch from develop to release-7.1.0 November 21, 2024 14:51
@matheusbsilva137 matheusbsilva137 removed the request for review from a team November 21, 2024 14:52
@matheusbsilva137 matheusbsilva137 changed the title chore: Update and notify subscriptions on contact name update regression: Update and notify subscriptions on contact name update Nov 21, 2024
KevLehman
KevLehman requested changes Nov 22, 2024
View reviewed changes
apps/meteor/app/lib/server/lib/notifyListener.ts Outdated Show resolved Hide resolved
apps/meteor/server/models/raw/Subscriptions.ts Outdated Show resolved Hide resolved
apps/meteor/server/models/raw/Subscriptions.ts Outdated Show resolved Hide resolved
KevLehman
KevLehman previously approved these changes Nov 25, 2024
View reviewed changes
dougfabris
dougfabris approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good in the front

@matheusbsilva137 matheusbsilva137 added the stat: QA assured Means it has been tested and approved by a company insider label Nov 25, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 25, 2024
@kodiakhq kodiakhq bot merged commit 97edecc into release-7.1.0 Nov 26, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the chore/contact-name-update branch November 26, 2024 14:08
ggazzo pushed a commit that referenced this pull request Dec 5, 2024
@matheusbsilva137 @dougfabris @ggazzo
regression: Update and notify subscriptions on contact name update (#…
745f5f5 
…33939)

Co-authored-by: Douglas Fabris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougfabris dougfabris dougfabris approved these changes

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

@KevLehman KevLehman KevLehman approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@matheusbsilva137 @KevLehman @MarcosSpessatto @dougfabris