-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improve performance of users.listByStatus
on some circumstances
#33937
Conversation
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33937 +/- ##
========================================
Coverage 75.85% 75.85%
========================================
Files 509 509
Lines 22026 22026
Branches 5381 5381
========================================
Hits 16707 16707
Misses 4674 4674
Partials 645 645
Flags with carried forward coverage won't be shown. Click here to find out more.
|
listByStatus
on some circumstancesusers.listByStatus
on some circumstances
Proposed changes (including videos or screenshots)
$or
filters when no filter is provided, reducing time on returning first page (when the $or clause was passed, even when empty, Mongo was trying to match the regexes against the indexes, making it slow)active
users query, improving speedIssue(s)
https://rocketchat.atlassian.net/browse/CORE-500
Steps to test or reproduce
Further comments