feat: Persistent Chat Discussion Name wildcard #33920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 625b084 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33920 +/- ##
========================================
Coverage 75.18% 75.18%
========================================
Files 495 495
Lines 21600 21600
Branches 5362 5362
========================================
Hits 16241 16241
Misses 4717 4717
Partials 642 642
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
abhinavkrin
requested changes
Nov 11, 2024
KevLehman
reviewed
Nov 13, 2024
Co-authored-by: Kevin Aleman <[email protected]>
KevLehman
previously approved these changes
Nov 13, 2024
abhinavkrin
previously approved these changes
Nov 13, 2024
MartinSchoeler
dismissed stale reviews from abhinavkrin and KevLehman
via
e2d8d21
KevLehman
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
KevLehman
approved these changes
Nov 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Changes the VideoConf_Persistent_Chat_Discussion_Name to accept a wildcard to decide the position of the date in relation to the discussion name
Using the
[date]wildcard you can specify where the date should be in the name:If no wildcard is provided the date will default to the start of the string:
Issue(s)
CORE-805